mirror of
https://sourceware.org/git/glibc.git
synced 2025-12-20 01:12:17 +08:00
6b7067460f
Clang issues a warning for double alias redirection, indicating that thei
original symbol is used even if a weak definition attempts to override it.
For instance, in the construction:
int __internal_impl (...) {}
weak_alias (__internal_impl, external_impl);
#if SOMETHING
weak_alias (external_impl, another_external_impl)
#endif
Clang warns that another_external_impl always resolves to __internal_impl,
even if external_impl is a weak reference. Using the internal symbol for
both aliases resolves this warning.
This issue also occurs with certain libc_hidden_def usage:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_weak (__internal_alias)
In this case, using a strong_alias is sufficient to avoid the warning
(since the alias is internal, there is no need to use a weak alias).
However, for the constructions like:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_def (__internal_alias)
weak_alias (__internal_impl, external_alias)
libc_hidden_def (external_alias)
Clang warns that the internal external_alias will always resolve to
__GI___internal_impl, even if a weak definition of __GI_internal_impl is
overridden. For this case, a new macro named static_weak_alias is used
to create a strong alias for SHARED, or a weak_alias otherwise.
With these changes, there is no need to check and enable the
-Wno-ignored-attributes suppression when using clang.
Checked with a build on affected ABIs, and a full check on aarch64,
armhf, i686, and x86_64.
Reviewed-by: Sam James <sam@gentoo.org>
130 lines
3.2 KiB
C
130 lines
3.2 KiB
C
/* Convert string representation of a number into an integer value.
|
|
Copyright (C) 1991-2025 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#include <features.h>
|
|
#undef __GLIBC_USE_C23_STRTOL
|
|
#define __GLIBC_USE_C23_STRTOL 0
|
|
#include <stdlib.h>
|
|
#include <wchar.h>
|
|
#include <locale/localeinfo.h>
|
|
|
|
#ifndef UNSIGNED
|
|
# define UNSIGNED 0
|
|
# define INT LONG int
|
|
#else
|
|
# define INT unsigned LONG int
|
|
#endif
|
|
|
|
#if UNSIGNED
|
|
# ifdef USE_WIDE_CHAR
|
|
# ifdef QUAD
|
|
# define strtol wcstoull
|
|
# define __strtol_l __wcstoull_l
|
|
# define __isoc23_strtol __isoc23_wcstoull
|
|
# else
|
|
# define strtol wcstoul
|
|
# define __strtol_l __wcstoul_l
|
|
# define __isoc23_strtol __isoc23_wcstoul
|
|
# endif
|
|
# else
|
|
# ifdef QUAD
|
|
# define strtol strtoull
|
|
# define __strtol_l __strtoull_l
|
|
# define __isoc23_strtol __isoc23_strtoull
|
|
# else
|
|
# define strtol strtoul
|
|
# define __strtol_l __strtoul_l
|
|
# define __isoc23_strtol __isoc23_strtoul
|
|
# endif
|
|
# endif
|
|
#else
|
|
# ifdef USE_WIDE_CHAR
|
|
# ifdef QUAD
|
|
# define strtol wcstoll
|
|
# define __strtol_l __wcstoll_l
|
|
# define __isoc23_strtol __isoc23_wcstoll
|
|
# else
|
|
# define strtol wcstol
|
|
# define __strtol_l __wcstol_l
|
|
# define __isoc23_strtol __isoc23_wcstol
|
|
# endif
|
|
# else
|
|
# ifdef QUAD
|
|
# define strtol strtoll
|
|
# define __strtol_l __strtoll_l
|
|
# define __isoc23_strtol __isoc23_strtoll
|
|
# endif
|
|
# endif
|
|
#endif
|
|
|
|
|
|
/* If QUAD is defined, we are defining `strtoll' or `strtoull',
|
|
operating on `long long int's. */
|
|
#ifdef QUAD
|
|
# define LONG long long
|
|
#else
|
|
# define LONG long
|
|
#endif
|
|
|
|
|
|
#ifdef USE_WIDE_CHAR
|
|
# define STRING_TYPE wchar_t
|
|
#else
|
|
# define STRING_TYPE char
|
|
#endif
|
|
|
|
|
|
#define INTERNAL(X) INTERNAL1(X)
|
|
#define INTERNAL1(X) __##X##_internal
|
|
|
|
#define SYM__(X) SYM__1 (X)
|
|
#define SYM__1(X) __ ## X
|
|
#define __strtol SYM__ (strtol)
|
|
|
|
|
|
extern INT INTERNAL (__strtol_l) (const STRING_TYPE *, STRING_TYPE **, int,
|
|
int, bool, locale_t);
|
|
|
|
|
|
INT
|
|
INTERNAL (strtol) (const STRING_TYPE *nptr, STRING_TYPE **endptr,
|
|
int base, int group)
|
|
{
|
|
return INTERNAL (__strtol_l) (nptr, endptr, base, group, false,
|
|
_NL_CURRENT_LOCALE);
|
|
}
|
|
libc_hidden_def (INTERNAL (strtol))
|
|
|
|
|
|
INT
|
|
__strtol (const STRING_TYPE *nptr, STRING_TYPE **endptr, int base)
|
|
{
|
|
return INTERNAL (__strtol_l) (nptr, endptr, base, 0, false,
|
|
_NL_CURRENT_LOCALE);
|
|
}
|
|
static_weak_alias (__strtol, strtol)
|
|
libc_hidden_weak (strtol)
|
|
|
|
INT
|
|
__isoc23_strtol (const STRING_TYPE *nptr, STRING_TYPE **endptr, int base)
|
|
{
|
|
return INTERNAL (__strtol_l) (nptr, endptr, base, 0, true,
|
|
_NL_CURRENT_LOCALE);
|
|
}
|
|
libc_hidden_def (__isoc23_strtol)
|