mirror of
https://sourceware.org/git/glibc.git
synced 2025-12-20 01:12:17 +08:00
6b7067460f
Clang issues a warning for double alias redirection, indicating that thei
original symbol is used even if a weak definition attempts to override it.
For instance, in the construction:
int __internal_impl (...) {}
weak_alias (__internal_impl, external_impl);
#if SOMETHING
weak_alias (external_impl, another_external_impl)
#endif
Clang warns that another_external_impl always resolves to __internal_impl,
even if external_impl is a weak reference. Using the internal symbol for
both aliases resolves this warning.
This issue also occurs with certain libc_hidden_def usage:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_weak (__internal_alias)
In this case, using a strong_alias is sufficient to avoid the warning
(since the alias is internal, there is no need to use a weak alias).
However, for the constructions like:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_def (__internal_alias)
weak_alias (__internal_impl, external_alias)
libc_hidden_def (external_alias)
Clang warns that the internal external_alias will always resolve to
__GI___internal_impl, even if a weak definition of __GI_internal_impl is
overridden. For this case, a new macro named static_weak_alias is used
to create a strong alias for SHARED, or a weak_alias otherwise.
With these changes, there is no need to check and enable the
-Wno-ignored-attributes suppression when using clang.
Checked with a build on affected ABIs, and a full check on aarch64,
armhf, i686, and x86_64.
Reviewed-by: Sam James <sam@gentoo.org>
95 lines
2.8 KiB
C
95 lines
2.8 KiB
C
/* Copyright (C) 1996-2025 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
#include <ctype.h>
|
|
#include <wctype.h>
|
|
#include <locale/localeinfo.h>
|
|
|
|
#include "wchar-lookup.h"
|
|
|
|
/* Provide real-function versions of all the wctype macros. */
|
|
|
|
#define func(name, type) \
|
|
extern int __isw##name (wint_t __wc); \
|
|
int \
|
|
__isw##name (wint_t wc) \
|
|
{ \
|
|
if (isascii (wc)) \
|
|
return is##name ((int) wc); \
|
|
size_t i = _NL_CURRENT_WORD (LC_CTYPE, _NL_CTYPE_CLASS_OFFSET) + type; \
|
|
const char *desc = _NL_CURRENT (LC_CTYPE, i); \
|
|
return wctype_table_lookup (desc, wc); \
|
|
} \
|
|
static_weak_alias (__isw##name, isw##name)
|
|
|
|
#undef iswalnum
|
|
func (alnum, __ISwalnum)
|
|
libc_hidden_def (__iswalnum)
|
|
libc_hidden_weak (iswalnum)
|
|
#undef iswalpha
|
|
func (alpha, __ISwalpha)
|
|
libc_hidden_weak (iswalpha)
|
|
#undef iswblank
|
|
func (blank, __ISwblank)
|
|
#undef iswcntrl
|
|
func (cntrl, __ISwcntrl)
|
|
#undef iswdigit
|
|
func (digit, __ISwdigit)
|
|
libc_hidden_weak (iswdigit)
|
|
#undef iswlower
|
|
func (lower, __ISwlower)
|
|
libc_hidden_def (__iswlower)
|
|
libc_hidden_weak (iswlower)
|
|
#undef iswgraph
|
|
func (graph, __ISwgraph)
|
|
#undef iswprint
|
|
func (print, __ISwprint)
|
|
#undef iswpunct
|
|
func (punct, __ISwpunct)
|
|
#undef iswspace
|
|
func (space, __ISwspace)
|
|
libc_hidden_weak (iswspace)
|
|
#undef iswupper
|
|
func (upper, __ISwupper)
|
|
#undef iswxdigit
|
|
func (xdigit, __ISwxdigit)
|
|
libc_hidden_weak (iswxdigit)
|
|
|
|
#undef towlower
|
|
wint_t
|
|
__towlower (wint_t wc)
|
|
{
|
|
size_t i = _NL_CURRENT_WORD (LC_CTYPE, _NL_CTYPE_MAP_OFFSET) + __TOW_tolower;
|
|
const char *desc = _NL_CURRENT (LC_CTYPE, i);
|
|
return wctrans_table_lookup (desc, wc);
|
|
}
|
|
libc_hidden_def (__towlower)
|
|
static_weak_alias (__towlower, towlower)
|
|
libc_hidden_weak (towlower)
|
|
|
|
#undef towupper
|
|
wint_t
|
|
__towupper (wint_t wc)
|
|
{
|
|
size_t i = _NL_CURRENT_WORD (LC_CTYPE, _NL_CTYPE_MAP_OFFSET) + __TOW_toupper;
|
|
const char *desc = _NL_CURRENT (LC_CTYPE, i);
|
|
return wctrans_table_lookup (desc, wc);
|
|
}
|
|
libc_hidden_def (__towupper)
|
|
static_weak_alias (__towupper, towupper)
|
|
libc_hidden_weak (towupper)
|