mirror of
https://github.com/grafana/grafana.git
synced 2025-12-20 11:40:21 +08:00
Revert: Remove unnecessary Alpine/Ubuntu conditional logic
- Real issue was wrong environment variable name (dashboardScene vs DISABLE_SCENES) - Keep Ubuntu base (original main branch behavior) for simplicity - Container base was not the root cause of old arch failures
This commit is contained in:
8
.github/workflows/pr-e2e-tests.yml
vendored
8
.github/workflows/pr-e2e-tests.yml
vendored
@@ -110,16 +110,16 @@ jobs:
|
||||
path: e2e/panels-suite
|
||||
- suite: various-suite (old arch)
|
||||
path: e2e/old-arch/various-suite
|
||||
flags: --flags="--env dashboardScene=false"
|
||||
flags: --flags="--env DISABLE_SCENES=true"
|
||||
- suite: dashboards-suite (old arch)
|
||||
path: e2e/old-arch/dashboards-suite
|
||||
flags: --flags="--env dashboardScene=false"
|
||||
flags: --flags="--env DISABLE_SCENES=true"
|
||||
- suite: smoke-tests-suite (old arch)
|
||||
path: e2e/old-arch/smoke-tests-suite
|
||||
flags: --flags="--env dashboardScene=false"
|
||||
flags: --flags="--env DISABLE_SCENES=true"
|
||||
- suite: panels-suite (old arch)
|
||||
path: e2e/old-arch/panels-suite
|
||||
flags: --flags="--env dashboardScene=false"
|
||||
flags: --flags="--env DISABLE_SCENES=true"
|
||||
name: ${{ matrix.suite }}
|
||||
runs-on: ubuntu-latest-8-cores
|
||||
permissions:
|
||||
|
||||
@@ -74,17 +74,8 @@ func GrafanaService(ctx context.Context, d *dagger.Client, opts GrafanaServiceOp
|
||||
WithExec([]string{"yarn", "install", "--immutable"}).
|
||||
WithExec([]string{"yarn", "e2e:plugin:build"})
|
||||
|
||||
// Conditional container base: Alpine for OSS (better old arch compatibility), Ubuntu for Enterprise (image renderer support)
|
||||
var container *dagger.Container
|
||||
if opts.InstallImageRenderer {
|
||||
// Ubuntu needed for image renderer (Enterprise workflows)
|
||||
container = d.Container().From("ubuntu:latest")
|
||||
} else {
|
||||
// Alpine for OSS - better compatibility with original release-12.0.3 and old arch tests
|
||||
container = d.Container().From("alpine").WithExec([]string{"apk", "add", "bash"})
|
||||
}
|
||||
|
||||
container = container.
|
||||
// Ubuntu base for modern daggerbuild system (supports image renderer + glibc requirements)
|
||||
container := d.Container().From("ubuntu:latest").
|
||||
WithMountedFile("/src/grafana.tar.gz", opts.GrafanaTarGz).
|
||||
WithExec([]string{"mkdir", "-p", "/src/grafana"}).
|
||||
WithExec([]string{"tar", "--strip-components=1", "-xzf", "/src/grafana.tar.gz", "-C", "/src/grafana"}).
|
||||
|
||||
Reference in New Issue
Block a user