8 Commits

Author	SHA1	Message	Date
Bob Beck	2fab90bb5e	4.0-POST-CLANG-FORMAT-WEBKIT ... Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org> (Merged from https://github.com/openssl/openssl/pull/29242)	2025-12-09 00:28:19 -07:00
Bob Beck	3a815c1481	Disable clang-format around line-wrap sensitive lines in malloc_test.c ... If OPENSSL_LINE ends up on a different line than the following call here, this test breaks. We should perhaps reconsider if testing the reporting of OPENSSL_LINE is what we want in a malloc test, but that's for another time than now. Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/29241)	2025-12-03 14:40:56 +01:00
Eugene Syromiatnikov	6c02774fd3	Explicitly limit the OPENSSL_aligned_alloc()'s alignment to 65536 ... There is little need to support alignments larger than a page size, and the open-coded OPENSSL_aligned_alloc() implementation implements that support in quite wasteful manner, so it is better just to limit the maximum supported alignment explicitly. The value of 65536 has been chosen so it is architecture-agnostic and is no less than page sizes used in commonly occurring architectures (and also it is a pretty number). Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Saša Nedvědický <sashan@openssl.org> (Merged from https://github.com/openssl/openssl/pull/28295)	2025-09-16 09:59:13 -04:00
Eugene Syromiatnikov	f75a6d951a	crypto/mem.c: use open-coded aligned alloc when posix_memalign fails ... While posix_memalign() is generally not expected to fail, we can always use the internal aligned alloc implementation to ensure that any OPENSSL_aligned_malloc failure is indeed fatal and does not require a fallback. Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Saša Nedvědický <sashan@openssl.org> (Merged from https://github.com/openssl/openssl/pull/28295)	2025-09-16 09:59:13 -04:00
Eugene Syromiatnikov	1be238a972	Move OPENSSL_SMALL_FOOTPRINT-related logic from aligned_alloc to the only caller ... Originally, CRYPTO_aligned_alloc() returned NULL if OpenSSL was built with OPENSSL_SMALL_FOOTPRINT defined, which is a weird place for such a consideration; moreover it means that every caller requires to implement some form of a fallback (and manually over-allocate and then align the returned memory if the alignment is a requirement), which is counter-productive (and outright ridiculous in environments with posix_memalign() available). Move the OPENSSL_SMALL_FOOTPRINT consideration to the only current caller and update the documentation and tests accordingly. Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Saša Nedvědický <sashan@openssl.org> (Merged from https://github.com/openssl/openssl/pull/28295)	2025-09-16 09:59:13 -04:00
Eugene Syromiatnikov	a0a73f52ad	test/mem_alloc_test.c: tfix in test_xaligned_alloc ... Change "=" to "==" in "if ((exp == EXP_NONNULL) ...". Fixes: d090695101 "test: add a sanity test for memory allocation functions" Resolves: https://scan5.scan.coverity.com/#/project-view/65279/10222?selectedIssue=1662047 Resolves: https://scan5.scan.coverity.com/#/project-view/65279/10222?selectedIssue=1662049 Related: https://github.com/openssl/project/issues/1317 Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from https://github.com/openssl/openssl/pull/28238)	2025-08-19 14:47:54 -04:00
Eugene Syromiatnikov	2b76895152	test/mem_alloc_test.c: avoid referencing potentially freed old_ret ... Referencing to old_ret after it has been freed by realloc is UB, so drop its usage in the printing routine, and don't check it for being non-NULL (as it is not a mistake to call free() on NULL pointer anyway). Fixes: d090695101 "test: add a sanity test for memory allocation functions" Resolves: https://scan5.scan.coverity.com/#/project-view/65279/10222?selectedIssue=1662052 Related: https://github.com/openssl/project/issues/1317 Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from https://github.com/openssl/openssl/pull/28238)	2025-08-19 14:47:54 -04:00
Eugene Syromiatnikov	d090695101	test: add a sanity test for memory allocation functions ... Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from https://github.com/openssl/openssl/pull/28059)	2025-08-08 12:22:10 -04:00