67 Commits

Author	SHA1	Message	Date
Bob Beck	2fab90bb5e	4.0-POST-CLANG-FORMAT-WEBKIT ... Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org> (Merged from https://github.com/openssl/openssl/pull/29242)	2025-12-09 00:28:19 -07:00
Nikola Pajkovsky	60e699a454	clang deprecates sprintf on macos ... test/threadstest.c:1376:9: error: 'sprintf' is deprecated. The same issues is in the ossl-nghttp3-demo. Signed-off-by: Nikola Pajkovsky <nikolap@openssl.org> Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from https://github.com/openssl/openssl/pull/28903)	2025-10-21 07:56:03 -04:00
Bernd Edlinger	5909d0d3fc	Add a test for multi-threaded OBJ_create ... After a successful OBJ_create the returned NID should be the same NID that is returned from OBJ_ln2nid and should not change any more, but after an unsuccessful OBJ_create, another thread must have created the object, therefore OBJ_ln2nid should not return NID_undef in that case. Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/28582)	2025-09-25 11:23:52 +02:00
Bernd Edlinger	a1f6bbf6b0	Fix logic errors in torture_rw_high/low test ... "old" was never assigned anything and the first assignment to "*iterations" in the loop was superfluous. Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/28574)	2025-09-17 16:11:27 -04:00
Bernd Edlinger	17d5c9297e	Add one more trace message to the torture_rcu_high test ... It is interesting that in the very rare cases, where this test failure has been observed so far, the rcu torture value went always backwards to 0. This could be either due to ossl_rcu_deref(&writer_ptr) returning NULL, or the initial value of "new = CRYPTO_zalloc(sizeof(uint64_t), NULL, 0)" still visible despite ossl_rcu_assign_ptr(&writer_ptr, &new) immediatley after the "*new = global_ctr++" statement. Add one additional trace message to find out what exactly happens here, when it happens again. Additionally, we do no longer initialize the new value to zero but something else, so it can also be detected. Related to #27267 Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/28487)	2025-09-10 22:32:55 +02:00
Matt Caswell	994774b4ca	Add a test for accessing an X509_STORE from multiple threads ... Check we don't have any threading issues when accessing an X509_STORE simultaneously Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/28198)	2025-08-21 14:39:43 +02:00
Neil Horman	036a46d2a4	Fix failure checking on rcu_read_lock ... during memfail testing: https://github.com/openssl/openssl/actions/runs/16794088536/job/47561223902 We get lots of test failures in ossl_rcu_read_lock. This occurs because we have a few cases in the read lock path that attempt mallocs, which, if they fail, trigger an assert or a silent failure, which isn't really appropriate. We should instead fail gracefully, by informing the caller that the lock failed, like we do for CRYPTO_THREAD_read_lock. Fortunately, these are all internal apis, so we can convert ossl_rcu_read_lock to return an int indicating success/failure, and fail gracefully during the test, rather than hitting an assert abort. Fixes openssl/project#1315 Reviewed-by: Paul Yang <paulyang.inf@gmail.com> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Paul Dale <ppzgs1@gmail.com> (Merged from https://github.com/openssl/openssl/pull/28195)	2025-08-09 09:22:13 -04:00
Tomas Mraz	a3af1c036c	test: Silence warnings on Win64 builds ... Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27806)	2025-07-02 17:26:26 +02:00
Neil Horman	b994ce4088	Add a test to confirm that we can repeatedly create and destroy keys ... Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Saša Nedvědický <sashan@openssl.org> (Merged from https://github.com/openssl/openssl/pull/27775)	2025-06-06 13:49:39 -04:00
openssl-machine	0c679f5566	Copyright year updates ... Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Release: yes	2025-03-12 13:35:59 +00:00
Bernd Edlinger	6e7be995fd	RCU: Ensure that qp's are actually retired in order ... The current retirement code for rcu qp's has a race condition, which can cause use-after-free errors, but only if more than 3 QPs are allocated, which is not the default configuration. This fixes an oversight in commit 5949918f9a ("Rework and simplify RCU code") Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26952)	2025-03-05 16:04:16 +01:00
Bernd Edlinger	4d16d2f40a	Re-enable RCU torture test on MACOSX ... This test was disabled due to "Stochastic failures in the RCU test on MACOSX" by #23967, which sounds like an issue that is probably fixed now. Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/26834)	2025-02-22 17:43:15 +01:00
Tomas Mraz	420d5d6294	Add test for releasing a shared EVP_PKEY across threads ... Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25664)	2024-12-10 14:57:53 +01:00
ArtSin	ccaa754b5f	Fix uses of EVP_PKEY_Q_keygen with size_t variadic argument ... Fix cases where `int` argument was passed instead of `size_t`. CLA: trivial Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25857)	2024-11-05 13:49:08 +01:00
Georgi Valkov	16beec98d2	threads_win: fix build error with VS2010 x86 ... InterlockedAnd64 and InterlockedAdd64 are not available on VS2010 x86. We already have implemented replacements for other functions, such as InterlockedOr64. Apply the same approach to fix the errors. A CRYPTO_RWLOCK rw_lock is added to rcu_lock_st. Replace InterlockedOr64 and InterlockedOr with CRYPTO_atomic_load and CRYPTO_atomic_load_int, using the existing design pattern. Add documentation and tests for the new atomic functions CRYPTO_atomic_add64, CRYPTO_atomic_and Fixes: libcrypto.lib(libcrypto-lib-threads_win.obj) : error LNK2019: unresolved external symbol _InterlockedAdd64 referenced in function _get_hold_current_qp libcrypto.lib(libcrypto-lib-threads_win.obj) : error LNK2019: unresolved external symbol _InterlockedOr referenced in function _get_hold_current_qp libcrypto.lib(libcrypto-lib-threads_win.obj) : error LNK2019: unresolved external symbol _InterlockedAnd64 referenced in function _update_qp libcrypto.lib(libcrypto-lib-threads_win.obj) : error LNK2019: unresolved external symbol _InterlockedOr64 referenced in function _ossl_synchronize_rcu Signed-off-by: Georgi Valkov <gvalkov@gmail.com> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/24405)	2024-07-01 10:02:02 +02:00
Neil Horman	f7252d736d	Some minor nit corrections in the thread code for rcu ... Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/24630) (cherry picked from commit d38d264228)	2024-06-20 16:56:39 +02:00
Tomas Mraz	fb6584987a	OSSL_LIB_CTX_load_config() must not be called concurrently on same libctx ... The semantics of such concurrent call is not defined. Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from https://github.com/openssl/openssl/pull/24275)	2024-05-09 09:20:58 +02:00
Jiasheng Jiang	327261c076	test/threadstest.c: Add checks for CRYPTO_THREAD_lock_new() ... Add checks for the return value of CRYPTO_THREAD_lock_new() in order to avoid Null pointer dereference. Fixes: 5f8b812931 ("Add locking to atomic operations in rw/rcu tests") Fixes: d0e1a0ae70 ("RCU lock implementation") Fixes: 71a04cfca0 ("Implement new multi-threading API") Signed-off-by: Jiasheng Jiang <jiasheng@purdue.edu> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/24313)	2024-05-06 10:24:22 +02:00
Neil Horman	d092208bd6	Fix potential divide by zero error ... Coverity caught the following issues: 1591477 1591475 1591473 1591470 all of which are simmilar, in that they catch potential divide by zero in double values. It can't actually happen since the the threads which increment these counters don't exit until they reach non-zero values, but its easy to add the checks, so lets do that to ensure that we don't change something in the future that causes it. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from https://github.com/openssl/openssl/pull/23462)	2024-04-24 11:39:41 +10:00
Neil Horman	24d16d3a19	Make rcu_thread_key context-aware ... Currently, rcu has a global bit of data, the CRYPTO_THREAD_LOCAL object to store per thread data. This works in some cases, but fails in FIPS, becuase it contains its own copy of the global key. So 1) Make the rcu_thr_key a per-context variable, and force ossl_rcu_lock_new to be context aware 2) Store a pointer to the context in the lock object 3) Use the context to get the global thread key on read/write lock 4) Use ossl_thread_start_init to properly register a cleanup on thread exit 5) Fix up missed calls to OSSL_thread_stop() in our tests Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/24162)	2024-04-19 09:22:53 -04:00
Richard Levitte	b646179229	Copyright year updates ... Reviewed-by: Neil Horman <nhorman@openssl.org> Release: yes (cherry picked from commit 0ce7d1f355) Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/24034)	2024-04-09 13:43:26 +02:00
Neil Horman	5f8b812931	Add locking to atomic operations in rw/rcu tests ... I neglected to add locks to the calls to CRYPTO_atomic_add in these test, which on newer compilers is fine, as atomic operations are defined. However on older compilers the __ATOMIC_ACQ_REL definition is missing causing these function to be implemented using an rwlock, which when NULL causes the locks to fail. Fix this my creating the lock and using them appropriately Fixes #24000 Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <ppzgs1@gmail.com> (Merged from https://github.com/openssl/openssl/pull/24001)	2024-04-02 04:12:16 -04:00
Neil Horman	1967539e21	Fix threadstest wrapping again ... Stochastic failures in the RCU test on MACOSX are occuring. Due to beta release, disabling this test on MACOSX until post 3.3 release Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/23967)	2024-03-26 10:27:23 -04:00
Neil Horman	b50c174ee3	Make counters in rcu/rw threads torture test 64 bit ... Its possible in some conditions for the rw/rcu torture tests to wrap the counter, leading to false positive failures, make them 64 bits to avoid this Reviewed-by: Shane Lontis <shane.lontis@oracle.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/23724)	2024-03-22 11:06:59 +01:00
Neil Horman	d0e1a0ae70	RCU lock implementation ... Introduce an RCU lock implementation as an alternative locking mechanism to openssl. The api is documented in the ossl_rcu.pod file Read side implementaiton is comparable to that of RWLOCKS: ossl_rcu_read_lock(lock); < critical section in which data can be accessed via ossl_derefrence > ossl_rcu_read_unlock(lock); Write side implementation is: ossl_rcu_write_lock(lock); < critical section in which data can be updated via ossl_assign_pointer and stale data can optionally be scheduled for removal via ossl_rcu_call > ossl_rcu_write_unlock(lock); ... ossl_synchronize_rcu(lock); ossl_rcu_call fixup Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/22729)	2024-02-01 08:33:25 -05:00
Matt Caswell	da1c088f59	Copyright year updates ... Reviewed-by: Richard Levitte <levitte@openssl.org> Release: yes	2023-09-07 09:59:15 +01:00
Matt Caswell	29f25a10e5	Test loading a PEM file from multiple threads ... The new decoder optimisation has some locking involved so we confirm that reading a PEM file from multiple threads works as expected. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from https://github.com/openssl/openssl/pull/21426)	2023-07-17 08:12:06 +10:00
Tomas Mraz	c48c32807f	Split out thread pool tests into threadpool_test ... Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from https://github.com/openssl/openssl/pull/19695)	2022-11-22 17:08:23 +01:00
Čestmír Kalina	4f32754f79	crypto: thread: remove ossl_crypto_thread_native_terminate ... Signed-off-by: Čestmír Kalina <ckalina@redhat.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from https://github.com/openssl/openssl/pull/19473)	2022-10-21 19:57:16 +02:00
Čestmír Kalina	6ca4bd2e4c	test: threads: replace test_thread_noreturn ... While POSIX threads are cancellable and may be asynchronously cancelled, their cancellation is not guaranteed by the POSIX standard. test_thread_noreturn, which simulates a long-running possibly unresponsive thread: THREAD #1 THREAD #2 LOCK L1 SPAWN #2 LOCK L1 On MacOS, cancelling such thread only queues cancellation request, but the following pthread_join hangs. Replace this implementation by an unbounded sequence of sleeps instead. Signed-off-by: Čestmír Kalina <ckalina@redhat.com> Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/19433)	2022-10-21 12:44:56 +02:00
Čestmír Kalina	4e43bc06f7	crypto: thread: serialize concurrent joins ... Multiple concurrent joins with a running thread suffer from a race condition that allows concurrent join calls to perform concurrent arch specific join calls, which is UB on POSIX, or to concurrently execute join and terminate calls. As soon as a thread T1 exists, one of the threads that joins with T1 is selected to perform the join, the remaining ones await completion. Once completed, the remaining calls immediately return. If the join failed, another thread is selected to attempt the join operation. Forcefully terminating a thread that is in the process of joining another thread is not supported. Common code from thread_posix and thread_win was refactored to use common wrapper that handles synchronization. Signed-off-by: Čestmír Kalina <ckalina@redhat.com> Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/19433)	2022-10-21 12:44:56 +02:00
Čestmír Kalina	4574a7fd8d	crypto: add preemptive threading support ... Some primitives are designed to be used in a multi-threaded environment, if supported, e.g., Argon2. This patch adds support for preemptive threading and basic synchronization primitives for platforms compliant with POSIX threads or Windows CRT. Native functions are wrapped to provide a common (internal) API. Threading support can be disabled at compile time. If enabled, threading is disabled by default and needs to be explicitly enabled by the user. Thread enablement requires an explicit limit on the number of threads that OpenSSL may spawn (non-negative integer/infinity). The limit may be changed. Signed-off-by: Čestmír Kalina <ckalina@redhat.com> Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/12255)	2022-10-17 09:45:39 +01:00
Hugo Landau	b88ce46ee8	BIO_s_dgram_pair ... Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from https://github.com/openssl/openssl/pull/18442)	2022-09-23 11:59:13 +10:00
Hugo Landau	ef7a9b44f0	Make OSSL_LIB_CTX_load_config thread safe ... Fixes #18226. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/18331)	2022-06-01 09:00:41 +01:00
Matt Caswell	fecb3aae22	Update copyright year ... Reviewed-by: Tomas Mraz <tomas@openssl.org> Release: yes	2022-05-03 13:34:51 +01:00
Pauli	3d4d5305c2	threadstest: use locking for tsan operations if required ... Not all platforms support tsan operations, those that don't need to have an alternative locking path. Fixes #17447 Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from https://github.com/openssl/openssl/pull/17479)	2022-01-13 21:46:34 +11:00
Pauli	1fc97807d3	threadstest: add write check to lock checking ... Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from https://github.com/openssl/openssl/pull/17479)	2022-01-13 21:46:34 +11:00
Peiwei Hu	0650ac437b	Fix EVP_PKEY_decrypt return check ... Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/17028)	2021-11-22 14:43:44 +01:00
Matt Caswell	293e251e6f	Extend the test_multi_load() test ... Run more threads and load the legacy provider (which uses a child lib ctx) in order to hit more possible thread failures. Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/16980)	2021-11-12 17:16:14 +00:00
Pauli	0855591e1f	test: add threading test for object creation ... In addition, rework the multi tests to use common code. Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/15713)	2021-09-25 10:39:20 +10:00
Pauli	b9bc8eb054	test: fix test ordering in threads test ... Fixes #15953 Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/15954)	2021-06-30 17:54:45 +10:00
Rich Salz	c3932c34cd	Always wait for both threads to finish ... Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from https://github.com/openssl/openssl/pull/15708)	2021-06-16 15:43:48 +01:00
Pauli	b3135f56a6	test: fix typo in comment in threadstest.c ... Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/15278)	2021-05-24 09:39:15 +10:00
Pauli	235776b2c7	test: add test case to reliably reproduce RAND leak during POST ... The FIPS provider leaks a RAND if the POST is run at initialisation time. This test case reliably reproduces this event. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/15278)	2021-05-24 09:39:15 +10:00
Pauli	9a633a1c97	test: fix thread test config file problem ... Force the thread test to use the configuration file via a command line arg. Use the test library support for libctx creation. Fixes #15243 Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from https://github.com/openssl/openssl/pull/15256)	2021-05-13 14:22:20 +10:00
Dr. David von Oheimb	f925315203	Add convenience functions and macros for asymmetric key generation ... Add EVP_PKEY_gen(), EVP_PKEY_Q_gen(), EVP_RSA_gen(), and EVP_EC_gen(). Also export auxiliary function OSSL_EC_curve_nid2name() and improve deprecation info on RSA and EC key generation/management functions. Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from https://github.com/openssl/openssl/pull/14695)	2021-05-11 12:46:42 +02:00
Matt Caswell	98369ef25f	Add a threading test for loading/unloading providers ... Check that we don't see any threading issues when loading/unloading a provider from multiple threads. Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from https://github.com/openssl/openssl/pull/15010)	2021-04-28 15:51:10 +01:00
Pauli	a135dea4e0	test: fix problem with threads test using default library context. ... Also add a new test that deliberately tests the default library context. Fixes #14720 Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/14773)	2021-04-08 17:46:35 +10:00
Pauli	8c63532002	test: fix coverity 1473609 & 1473610: unchecked return values ... Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/14615)	2021-03-26 08:46:02 +10:00
Pauli	743840d56f	test: fix coverity 1451562: resource leak ... Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/14596)	2021-03-20 10:07:59 +10:00