Note that there are still 2 mentions of "RAX40" in comments, but they
were kept because one of them is a TODO item that will be removed in
the future, and the other one is about a test that was done
specifically on a RAX40.
Fixes PPM-1720
Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
There was some discussion about the rule that a commit should never
break anything. It turns out that this rule is not that important after
all (since we've never used git bisect up to now), and in some cases it
makes our life a lot easier if a braking commit is allowed. Also, some
MRs have had breaking commits already, and there wasn't a big problem.
Therefore, relax the constraint about non-breaking commits a bit, with
an explanation why.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
This is an attempt at keeping the docs up to date with the move from github to gitlab.
Since this document will be used as a template for prplWrt as well, it's double important that it stays up to date.
I anticipate we'll need another update once the move is complete and we've settled on how to work effectively with gitlab a bit more.
The "Merge request workflow" in particular might change significantly, but I don't want to do it yet because I'm not certain yet what it will look like.
Also, I don't know how (if) the DCO check still works with gitlab, or if we need to tweak things a little there.
No doubt we'll discover other issues.
So, this is just an *initial version* of the contribution guidelines, adapted for gitlab.
See PPM-335
Signed-off-by: Frederik Van Bogaert <frederik.vanbogaert@mind.be>
I'm disabling the github wiki in favor of confluence,
so make sure to link people to the right place.
Signed-off-by: Frederik Van Bogaert <frederik.vanbogaert@essensium.com>
Although REUSE does not require it, it is advised to use the
SPDX-FileCopyrightText. Since we're anyway doing treewide updates here,
we can just as well do one more now.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Currently, a PR will be merged automatically as soon as it has two
reviews and passes CI. However, there have been a few cases where this
was a bit premature, i.e. something was still supposed to have changed.
Require an explicit "ready for merge" label to trigger automatic
merging.
Update CONTRIBUTING.md with this workflow.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Until we have a capable test framework (possibly boardfarm), which will
verify each test flow on a real device, some changes can break real
devices in certification if they are not tested in a real device.
For that we have a section in the wiki which provides every developer an
easy way to run any test on his branch.
Developers who change a piece of code which may impact some
certification flow, for example changing topology handling, or
autoconfig, etc. - should be tested with the relevant test.
Signed-off-by: Tomer Eliyahu <tomer.b.eliyahu@intel.com>
Convert the remaining tests to python, and remove test_flows.sh. The
remaining tests are optimal_path_dummy, client_steering_dummy,
client_steering_policy, client_association,
higher_layer_data_payload_trigger, and topology.
Since optimal_path_dummy doesn't work reliably, disable it by prepending
an underscore to the name. Also it should start with reconfiguring the
APs so each radio has a VAP with the same SSID.
Remove test_flows.sh from gitlab-ci, and rename run-tests-py to run-tests.
CONTRIBUTING.md refers to test_flows.py instead of test_flows.sh.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Moves all tests to the top level "tests" directory
Update paths that accessed files in the tests directory
to point to the new location.
This includes the test files itself, and some other files
needed for CI.
Namely, .gitlab-ci.yml has been updated with new paths.
Also, the mention of those tests in CONTRIBUTING.md was fixed.
Signed-off-by: Frederik Van Bogaert <frederik.vanbogaert@essensium.com>
Replace with gitlab CI where appropriate.
Also add missing reference to Turris, B1300 and RAX40 builds in CI.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
* Remove mentions of the mailing list, which has been abandoned.
* Fix some of the URLs in the document
Signed-off-by: Frederik Van Bogaert <frederik.vanbogaert@essensium.com>
Now that we have a full test to verify all flows, use that in travis CI.
Have travis test perform the topology test which is the only test
currently implemented. From now on, every new flow will include adding a
test to test_flows.sh and update travis accordingly.
Also update CONTRIBUTING.md accordingly.
Signed-off-by: Tomer Eliyahu <tomer.b.eliyahu@intel.com>
We can update this document as we decide on the coding style.
Also refer to this new document from CONTRIBUTING.md.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Update workflow to better describe how to work with fixup commits, when
to do rebase-force-push during review, etc.
Signed-off-by: Tomer Eliyahu <tomer.b.eliyahu@intel.com>
