mirror of
https://sourceware.org/git/glibc.git
synced 2025-12-20 01:12:17 +08:00
6b7067460f
Clang issues a warning for double alias redirection, indicating that thei
original symbol is used even if a weak definition attempts to override it.
For instance, in the construction:
int __internal_impl (...) {}
weak_alias (__internal_impl, external_impl);
#if SOMETHING
weak_alias (external_impl, another_external_impl)
#endif
Clang warns that another_external_impl always resolves to __internal_impl,
even if external_impl is a weak reference. Using the internal symbol for
both aliases resolves this warning.
This issue also occurs with certain libc_hidden_def usage:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_weak (__internal_alias)
In this case, using a strong_alias is sufficient to avoid the warning
(since the alias is internal, there is no need to use a weak alias).
However, for the constructions like:
int __internal_impl (...) {}
weak_alias (__internal_impl, __internal_alias)
libc_hidden_def (__internal_alias)
weak_alias (__internal_impl, external_alias)
libc_hidden_def (external_alias)
Clang warns that the internal external_alias will always resolve to
__GI___internal_impl, even if a weak definition of __GI_internal_impl is
overridden. For this case, a new macro named static_weak_alias is used
to create a strong alias for SHARED, or a weak_alias otherwise.
With these changes, there is no need to check and enable the
-Wno-ignored-attributes suppression when using clang.
Checked with a build on affected ABIs, and a full check on aarch64,
armhf, i686, and x86_64.
Reviewed-by: Sam James <sam@gentoo.org>
41 lines
1.6 KiB
Makefile
41 lines
1.6 KiB
Makefile
srcdir = @srcdir@
|
|
|
|
TEST_CC = @TEST_CC@
|
|
TEST_CXX = @TEST_CXX@
|
|
test-cc-option-wimplicit-fallthrough = @libc_cv_test_cc_wimplicit_fallthrough@
|
|
test-config-cflags-mprefer-vector-width = @libc_cv_test_cc_mprefer_vector_width@
|
|
test-config-cflags-signaling-nans = @libc_cv_test_cc_signaling_nans@
|
|
test-cc-option-wfree-labels = @libc_cv_test_cc_wfree_labels@
|
|
test-cc-option-wmissing-parameter-name = @libc_cv_test_cc_wmissing_parameter_name@
|
|
test-enable-cet = @test_enable_cet@
|
|
test-have-static-pie = @libc_cv_test_static_pie@
|
|
test-supported-fortify = @libc_cv_test_supported_fortify_source@
|
|
|
|
# Uncomment the line below if you want to do parallel build.
|
|
# PARALLELMFLAGS = -j 4
|
|
|
|
.PHONY: all install bench
|
|
|
|
all .DEFAULT:
|
|
$(MAKE) -r PARALLELMFLAGS="$(PARALLELMFLAGS)" -C $(srcdir) objdir=`pwd` $@
|
|
|
|
check xcheck test:
|
|
$(MAKE) -r PARALLELMFLAGS="$(PARALLELMFLAGS)" -C $(srcdir) \
|
|
CC="$(TEST_CC)" CXX="$(TEST_CXX)" \
|
|
cc-option-wimplicit-fallthrough="$(test-cc-option-wimplicit-fallthrough)" \
|
|
config-cflags-mprefer-vector-width="$(test-config-cflags-mprefer-vector-width)" \
|
|
config-cflags-signaling-nans="$(test-config-cflags-signaling-nans)" \
|
|
cc-option-wfree-labels="$(test-cc-option-wfree-labels)" \
|
|
cc-option-wmissing-parameter-name="$(test-cc-option-wmissing-parameter-name)" \
|
|
enable-cet="$(test-enable-cet)" \
|
|
have-static-pie="$(test-have-static-pie)" \
|
|
supported-fortify="$(test-supported-fortify)" \
|
|
objdir=`pwd` $@
|
|
|
|
install:
|
|
LC_ALL=C; export LC_ALL; \
|
|
$(MAKE) -r PARALLELMFLAGS="$(PARALLELMFLAGS)" -C $(srcdir) objdir=`pwd` $@
|
|
|
|
bench bench-clean bench-build:
|
|
$(MAKE) -C $(srcdir)/benchtests $(PARALLELMFLAGS) objdir=`pwd` $@
|