2362 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Paul Mackerras	1affa97637	Merge pull request #572 from jkroonza/dhcpv6-nonblock ... dhcpv6relay plugin: Make all sockets non-blocking.	2025-12-06 09:54:33 +11:00
Jaco Kroon	e109960df0	dhcpv6relay: Improve buffer overrun protection by using MSG_TRUNC. ... When calling recvfrom we can pass MSG_TRUNC to always get the number of bytes that was in the original packet (for non-connection oriented protocols such as UDP) rather than the number of bytes placed into the buffer. This allows us to compare the number of bytes in the packet to the size of the buffer rather than just the number of bytes placed in the buffer, allowing us to receive and process a full buffer rather than just 1 byte less than the buffer size. Technically this fixes an off by one error, but there should be no operational impact and highly unlikely to occur in the wild. Signed-off-by: Jaco Kroon <jaco@uls.co.za>	2025-10-29 13:08:41 +02:00
Jaco Kroon	adec08a7b5	dhcpv6relay: When responding to router solicitations, do so using ... unicast. https://datatracker.ietf.org/doc/html/rfc4861#section-4.2 states: Destination Address Typically the Source Address of an invoking Router Solicitation or the all-nodes multicast address. This implies we should respond *to* the requesting device only using unicast, thus make it so. Use recvfrom to achieve this, also making the socket non-blocking. If we fail to receive due to EWOULDBLOCK or EAGAIN - assume we "lost" a RS and just send a RA to multicast anyway. Signed-off-by: Jaco Kroon <jaco@uls.co.za>	2025-10-29 13:08:41 +02:00
Jaco Kroon	13291f4c08	dhcpv6relay plugin: Add support for NA. (#569) ... As it turns out some (I won't mention names) routers ends up using LL addresses when originating IPv6 traffic in the absense of IA_NA issued address (In spite of having IA_PD space available). This allows the DHCPv6 server to issue same and have routing function. Include some extra safeties too for processing IA_PD server responses as well. Signed-off-by: Jaco Kroon <jaco@uls.co.za>	2025-10-25 20:15:00 +01:00
Alexander Kanavin	15035c1936	pppd/Makefile.am: correctly install-but-not-distribute pppdconf.h (#570) ... BUILT_SOURCE statement had no effect, and is replaced by the correct statement (verified with 'make dist' and 'make install'). This should resolve https://github.com/ppp-project/ppp/issues/541 Signed-off-by: Alexander Kanavin <alex@linutronix.de>	2025-10-22 20:23:54 +01:00
Martin Olivier	7a4571660a	pppd: add VRF (Virtual Routing and Forwarding) binding support on Linux (#566) ... Add 'vrf' option to bind a PPP interface to a specific VRF, so that routes are installed in the VRF's routing table rather than the main routing table. This allows PPP sessions to operate in separate routing domains, providing isolation of traffic and routes. When this option is used, pppd sets the 'VRF' environment variable for ip-{up,down} scripts. Signed-off-by: Martin Olivier <martin.olivier@live.fr>	2025-10-03 19:16:54 +10:00
Paul Mackerras	a839700f35	Submitting-patches.md: minor update ... Signed-off-by: Paul Mackerras <paulus@ozlabs.org>	2025-08-15 08:48:28 +10:00
Paul Mackerras	3ae90e6091	configure.ac: Update version number to 2.5.3-dev ... Signed-off-by: Paul Mackerras <paulus@ozlabs.org>	2025-08-15 08:48:24 +10:00
Fallguy0815	ee9f4211bd	plugins/pppoe: Fix typo in pppoe-discovery.c help text (#565) ... Fix typo in usage(void) of pppoe-discovery. -Q should be described as Quiet (as in silent) mode, not Quit (as in exit) mode Signed-off-by: Gregor Heuer <gregwarrior@gmx.de>	2025-08-15 08:46:30 +10:00
Jaco Kroon	87c30d373b	Revert "pppd/options.c: fix memory leak on error path (#441)" (#562) ... This reverts commit 26d1b60f49. Additionally a comment is added so anyone looking at Coverity output will not be tempted to "fix" it again. Closes: #560 Signed-off-by: Jaco Kroon <jaco@uls.co.za>	2025-07-19 15:30:18 +10:00
Paul Mackerras	6f3bf58b84	Merge pull request #551 from jkroonza/dhcpv6relay ... dhcpv6relay plugin from Jaco Kroon	2025-05-15 18:09:42 +10:00
Jaco Kroon	e648da58d1	dhcpv6relay plugin: Add support for RS and RA ... We will now listed for RS (Router Solicitation) messages, and respond by sending a RA (Router Advertisement) stating that managed mode needs to be used both for address as well as supplementary (eg DNS) configurations. Also added an option to send RAs at pre-defined intervals. First instance is sent 1 second after IPv6CP comes up, and then thereafter at the relevant configured interval. Signed-off-by: Jaco Kroon <jaco@uls.co.za>	2025-05-07 23:36:19 +02:00
Jaco Kroon	7a4c2d6f35	dhcpv6relay plugin. ... After the plugin is loaded, it just needs dhcpv6-server option to know where to relay to. dhcpv6-trusted / dhcpv6-untrusted can be used to mark the port as trusted (will further forward relay-fwd messages) or unstrusted (will only accept and forward client originated messages. dhcpv6-metric - metric at which to install IPv6 routes into the kernel routing table for prefix delegations. Server needs to support fwd option 135 (aka relay-port) in order to respond to pppd. KEA (for one) does. Signed-off-by: Jaco Kroon <jaco@uls.co.za>	2025-05-02 13:07:56 +02:00
Jaco Kroon	b68270e54e	pppd: add sifaddroute and sifdelroute to the ppp api. ... This includes an implementation on Linux, and a placeholder on Solaris (which will need to be implemented to make dhcpv6relay module effective). Signed-off-by: Jaco Kroon <jaco@uls.co.za>	2025-05-02 12:01:23 +02:00
Jaco Kroon	97ca4321f5	pppd: Implement more generic event handler mechanism ... This allows non-core modules to add file descriptors to the event loop and have a call-back called when those file descriptors won't block on read(). Signed-off-by: Jaco Kroon <jaco@uls.co.za>	2025-05-02 12:01:23 +02:00
Khem Raj	fb769c380e	pppd: Fix building session.c with GCC 15 (#553) ... Fixed building with GCC 15 which defaults to C23 and find conflicting declration of getspnam() here with the one provided by shadow.h (extern struct spwd *getspnam (const char *__name);) Fixes ../../ppp-2.5.2/pppd/session.c: In function 'session_start': ../../ppp-2.5.2/pppd/session.c:185:18: error: conflicting types for 'getspnam'; have 'struct spwd *(void)' 185 | struct spwd *getspnam(); | ^~~~~~~~ Signed-off-by: Khem Raj <raj.khem@gmail.com>	2025-04-08 17:15:57 +10:00
Simon Arlott	7060ac7c50	pppd: Fix potential buffer overflow in lcp_rtt_update_buffer() (#554) ... It's possible for ring_header[2] to be modified by another process when reading it twice through a volatile pointer, causing it to change from a small value (which doesn't need to wrap around) to a large value which would exceed the size of the buffer. Signed-off-by: Simon Arlott <git@sa.me.uk> Co-authored-by: Simon Arlott <git@sa.me.uk>	2025-04-08 17:14:51 +10:00
Jaco Kroon	b17da86170	pppd: Suppress spurious ESRCH on route removal (#550) ... Signed-off-by: Jaco Kroon <jaco@uls.co.za>	2025-03-13 12:43:03 +11:00
Neal P. Murphy	b514c2c6e3	Move inclusion of <linux/ppp_ioctl.h> to allow geriatric systems to build ppp. (#552) ... Given a system with the following: - linux 4.4.302 - kernel headers 3.4.104 - gcc 4.7.3 - binutils 2.22 - glibc 2.18 Compiling ppp fails with the following errors: ==== x86_64-linux-gnu-gcc -std=gnu11 -DHAVE_CONFIG_H -I. -I../pppd/plugins/pppoe -DSYSCONFDIR=\"/usr/etc\" -DPPPD_RUNTIME_DIR='"/usr/var/run/pppd"' -DPPPD_LOGFILE_DIR='"/usr/var/log/ppp"' -DSYSTEM_CA_PATH='"/usr/etc/ssl/certs"' -DPPPD_PLUGIN_DIR='"/usr/lib/pppd/2.5.2"' -O2 -m64 -fPIC -MT pppd-sys-linux.o -MD -MP -MF .deps/pppd-sys-linux.Tpo -c -o pppd-sys-linux.o `test -f 'sys-linux.c' || echo './'`sys-linux.c In file included from sys-linux.c:125:0: /usr/include/linux/ppp-ioctl.h:55:14: error: field 'mode' has incomplete type make[3]: *** [Makefile:1334: pppd-sys-linux.o] Error 1 make[3]: Leaving directory '/build/sources/ppp/ppp-2.5.2/pppd' make[2]: *** [Makefile:819: all] Error 2 make[2]: Leaving directory '/build/sources/ppp/ppp-2.5.2/pppd' make[1]: *** [Makefile:505: all-recursive] Error 1 make[1]: Leaving directory '/build/sources/ppp/ppp-2.5.2' make: *** [Makefile:31: compile] Error 2 make: Leaving directory '/build/sources/ppp' ==== and ==== libtool: compile: x86_64-linux-gnu-gcc -std=gnu11 -DHAVE_CONFIG_H -I. -I../../../pppd -I../../../pppd/plugins/pppoe -I../../.. -O2 -m64 -fPIC -MT pppol2tp_la-pppol2tp.lo -MD -MP -MF .deps/pppol2tp_la-pppol2tp.Tpo -c pppol2tp.c -fPIC -DPIC -o .libs/pppol2tp_la-pppol2tp.o In file included from pppol2tp.c:41:0: /usr/include/linux/ppp-ioctl.h:55:14: error: field 'mode' has incomplete type make[3]: *** [Makefile:498: pppol2tp_la-pppol2tp.lo] Error 1 make[3]: Leaving directory '/build/sources/ppp/ppp-2.5.2/pppd/plugins/pppol2tp' make[2]: *** [Makefile:579: all-recursive] Error 1 make[2]: Leaving directory '/build/sources/ppp/ppp-2.5.2/pppd/plugins' make[1]: *** [Makefile:505: all-recursive] Error 1 make[1]: Leaving directory '/build/sources/ppp/ppp-2.5.2' make: *** [Makefile:31: compile] Error 2 make: Leaving directory '/build/sources/ppp' ==== They are likely due to the ordering of include files which changed in newer systems. Signed-off-by: NPMurphy <neal.p.murphy@alum.wpi.edu> Co-authored-by: NPMurphy <neal.p.murphy@alum.wpi.edu>	2025-03-13 12:41:09 +11:00
Jaroslav Škarvada	05361692ee	pppdump: Fixed building with GCC 15 (#548) ... GCC 15 defaults to C23 which does not allow K&R declarations. Credit Yaakov Selkowitz in: https://src.fedoraproject.org/rpms/ppp/pull-request/12 Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>	2025-02-28 09:00:16 +11:00
Jaco Kroon	cd6bb90135	pppd: Rework default route handling. (#544) ... 1. replacedefaultroute option is no longer functional. 2. default route will now always be appended at defaultroute-metric (both IPv4 and IPv6) if defaultroute{.6} is given. Closes: #473 Signed-off-by: Jaco Kroon <jaco@uls.co.za>	2025-02-24 09:03:03 +11:00
Chris Boot	b67c2965c3	pppd.8: Fix groff warning (#547) ... Signed-off-by: Chris Boot <bootc@debian.org>	2025-02-19 08:47:08 +11:00
Jaco Kroon	1b65ca2c93	Make a note about shell expansion in pppd man page for pty option. (#545) ... Signed-off-by: Jaco Kroon <jaco@uls.co.za>	2025-01-23 08:47:51 +11:00
Paul Mackerras	9f612dc02c	config: Include some extra files in the tarball ... Signed-off-by: Paul Mackerras <paulus@ozlabs.org> v2.5.2	2024-12-31 15:57:20 +11:00
Paul Mackerras	8eca3c738d	Update README and configure.ac for 2.5.2 release ... Signed-off-by: Paul Mackerras <paulus@ozlabs.org>	2024-12-31 10:10:55 +11:00
Paul Mackerras	a232b71403	Update a few more copyright notices ... Signed-off-by: Paul Mackerras <paulus@ozlabs.org>	2024-12-31 09:56:27 +11:00
Paul Mackerras	0885c4b266	configure: Make PEAP depend on microsoft extensions (#540) ... Since our only PEAP mechanism is MS-CHAP v2, the compile fails if we enable PEAP without MS extensions. Therefore, for now make PEAP depend on MS extensions, so if MS extensions are disabled, PEAP is automatically disabled. Signed-off-by: Paul Mackerras <paulus@ozlabs.org>	2024-12-31 09:45:06 +11:00
[anp/hsw]	5efd40cf3b	disable holdoff for reconnect on timeout or link failure (#538) ... Signed-off-by: [anp/hsw] <sysop@880.ru>	2024-12-30 16:21:55 +11:00
Jaco Kroon	95594918d0	.gitattributes to exclude .git* files from git-archive. (#539) ... This relates to #519 and addresses the portion where "we can also exclude things like /.github/ from the release". Signed-off-by: Jaco Kroon <jaco@uls.co.za>	2024-12-30 14:47:21 +11:00
Paul Mackerras	d4ec06ec58	Update my copyright notices and remove old RCS tags ... Make my copyright notices all consistently have a 2-clause BSD licence. Signed-off-by: Paul Mackerras <paulus@ozlabs.org>	2024-12-20 12:15:01 +11:00
DragonBluep	734bc0438e	pppd: Make pid directory before creating the pid file (#536) ... If multilink feature is not enabled, the '/var/run/pppd' directory won't be created before adding pid file. Fixes error message: 'Failed to create pid file /var/run/pppd/pppoe-wan.pid: No such file or directory' Signed-off-by: Shiji Yang <yangshiji66@outlook.com>	2024-11-26 20:14:42 +11:00
DragonBluep	3102b0b618	pppd: remove redundant rtentry device name init in cifdefaultroute() (#535) ... The rtentry device name has already been set in commit: 9856f47063 ("Specify the device name on the default route deletion") Fixes: 35e5a569c9 (pppd: add support for defaultroute-metric option) Signed-off-by: Shiji Yang <yangshiji66@outlook.com>	2024-11-21 14:17:22 +11:00
Tomas Paukrt	5f6eabdb66	pppd: Fix build without OpenSSL (#533) ... The symbol OPENSSL_VERSION_NUMBER is not defined when pppd is compiled without OpenSSL support, so it evaluates to zero. This results in the following linker error: crypto.c:241: undefined reference to `ERR_free_strings' Signed-off-by: Tomas Paukrt <tomaspaukrt@email.cz>	2024-11-21 13:53:28 +11:00
Paul Mackerras	616102e93b	Merge pull request #529 from ppp-project/springclean ... Springclean	2024-10-29 16:42:46 +11:00
orbea	d72b03393a	pppd: fix build with LibreSSL 4.0.0 (#526) ... Starting with LibreSSL 4.0.0 the OPENSSL_load_builtin_modules() function was removed. It is obsolete after automatic library initialization and now an internal API. Signed-off-by: orbea <orbea@riseup.net>	2024-10-29 16:42:18 +11:00
Tomas Paukrt	f7120b5cea	pppd: Fix printing 64-bit counters (#528) ... Add support of format specifiers %lld and %llu to the function vslprintf and use the correct specifiers for printing 64-bit counters. Signed-off-by: Tomas Paukrt <tomaspaukrt@email.cz>	2024-10-29 16:40:55 +11:00
Paul Mackerras	ef41a6dcb2	Delete samples/options.ttyXX ... The commentary and example in this file doesn't seem all that useful. Signed-off-by: Paul Mackerras <paulus@ozlabs.org>	2024-10-26 17:02:03 +11:00
Paul Mackerras	c24180bcf8	scripts: Remove some old scripts of dubious value ... This removes various scripts and config files that related to dial-up connections, doing PPP over rsh or ssh (for which there are better alternatives), and updating resolv.conf (for which distros have other mechanisms these days). Signed-off-by: Paul Mackerras <paulus@ozlabs.org>	2024-10-25 18:32:14 +11:00
Paul Mackerras	b9e627e212	Remove pppgetpass program ... This is associated with the passprompt plugin, and like it, seems not to be very useful any more now that no-one uses dial-up. Also, its function seems somewhat peripheral to PPP. Signed-off-by: Paul Mackerras <paulus@ozlabs.org>	2024-10-25 17:29:46 +11:00
Paul Mackerras	0a66ad22e5	pppd: Remove passprompt plugin ... This is prompted by a number of factors: * It was more useful back in the dial-up days, but no-one uses dial-up any more * In many cases there will be no terminal accessible to the prompter program at the point where the prompter is run * The passwordfd plugin does much the same thing but does it more cleanly and securely * The handling of privileges and file descriptors needs to be audited thoroughly. Signed-off-by: Paul Mackerras <paulus@ozlabs.org>	2024-10-25 17:26:46 +11:00
Paul Mackerras	346125f375	Update version to 2.5.2-dev ... Signed-off-by: Paul Mackerras <paulus@ozlabs.org>	2024-10-18 20:27:34 +11:00
nasbdh9	ac269dbf7c	pppd/crypto: Fix gcc 14 build (#524) ... Fix this: crypto.c: In function 'PPP_crypto_error': crypto.c:178:11: error: implicit declaration of function 'vsnprintf' [-Wimplicit-function-declaration] 178 | off = vsnprintf(buf, len, fmt, args); | ^~~~~~~~~ crypto.c:41:1: note: include '<stdio.h>' or provide a declaration of 'vsnprintf' 40 | #include "crypto-priv.h" +++ |+#include <stdio.h> 41 | crypto.c:178:26: warning: 'vsnprintf' argument 2 type is 'int' where 'long unsigned int' is expected in a call to built-in function declared without prototype [-Wbuiltin-declaration-mismatch] 178 | off = vsnprintf(buf, len, fmt, args); | ^~~ <built-in>: note: built-in 'vsnprintf' declared here Signed-off-by: Tan Zien <nabsdh9@gmail.com>	2024-10-15 13:53:48 +11:00
Paul Mackerras	ff28c30967	Bring Solaris port back up to date (#525) ... - Updated READMEs - Disabled MPPE support for Solaris - Fixed compilation error in ccp.c with MPPE disabled - Use OS-provided drivers and associated include files - Tested on OpenIndiana Hipster (Illumos) Signed-off-by: James Carlson <carlsonj@workingcode.com> Signed-off-by: Paul Mackerras <paulus@ozlabs.org> Co-authored-by: James Carlson <carlsonj@workingcode.com>	2024-10-15 13:20:29 +11:00
Jaco Kroon	d540579ce5	Export remote_number into REMOTENUMBER environment variable (#521) ... Signed-off-by: Jaco Kroon <jaco@uls.co.za>	2024-10-14 19:03:09 +11:00
Adrien RICCIARDI	0f6a7c95e1	ci: Update the Solaris action to benefit from the faster VM (#522) ... The total execution decreased by about 20%, sometimes even more. Signed-off-by: RICCIARDI-Adrien <adrien.ricciardi@hotmail.fr>	2024-10-14 19:01:50 +11:00
Paul Mackerras	d5aeec6575	Update README to fix an error ... Signed-off-by: Paul Mackerras <paulus@ozlabs.org> ppp-2.5.1 v2.5.1	2024-09-18 14:30:31 +10:00
Paul Mackerras	8918950194	Update version to 2.5.1 for release ... Signed-off-by: Paul Mackerras <paulus@ozlabs.org>	2024-09-18 14:02:31 +10:00
Paul Mackerras	bf52861d25	Update README for 2.5.1 release ... Signed-off-by: Paul Mackerras <paulus@ozlabs.org>	2024-09-18 14:02:28 +10:00
Paul Mackerras	367a47aa90	scripts: Update Makefile.am to reflect chatchat removal ... Signed-off-by: Paul Mackerras <paulus@ozlabs.org>	2024-09-18 14:02:21 +10:00
Paul Mackerras	1ced44aca8	Remove chatchat program ... It is old and unmaintained and I don't think anyone uses it. Signed-off-by: Paul Mackerras <paulus@ozlabs.org>	2024-09-18 13:49:38 +10:00