prpl-foundation/feed-qca
1
0
Fork 0
mirror of https://gitlab.com/prpl-foundation/prplOS/feed-qca.git synced 2025-12-20 01:21:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

qca-nss-dscpstats: Fix compilation issue when CONFIG_DYNAMIC_DEBUG is disabled

Browse Source 
When CONFIG_KERNEL_DYNAMIC_DEBUG is disabled in prplos configuration,
the qca-nss-dscpstats package fails to compile due to two issues:

1. Undefined debug level macro: The debug macros in nss_dscpstats.h
   reference 'nss_dscpstats_DEBUG_LEVEL' (lowercase) but this macro was
   never defined, causing compilation errors when dynamic debug is
   disabled.

2. Missing header file: The header file <linux/netdevice.h> was not
   included, which is required for network device related definitions.

This patch fixes both issues by:
- Adding -DNSS_DSCPSTATS_DEBUG_LEVEL=3 to the Makefile ccflags to define
  the debug level for static compilation
- Correcting the macro name from lowercase 'nss_dscpstats_DEBUG_LEVEL'
  to uppercase 'NSS_DSCPSTATS_DEBUG_LEVEL' in all debug level checks
- Including <linux/netdevice.h> header in nss_dscpstats.h

This allows compilation to succeed regardless of the
CONFIG_DYNAMIC_DEBUG setting while maintaining appropriate debug message
filtering based on the configured debug level.

Closes: PCF-2138

Signed-off-by: Nikhil Gurram <nikhgurr@qti.qualcomm.com>
Signed-off-by: Marvin Lu <marvin.lu@wnc.com.tw>
This commit is contained in:
Marvin Lu
2025-12-17 10:36:00 +08:00
parent 8cefe7f152
commit 0d3820f29a
1 changed files with 61 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

61
feeds/nss/clients/qca-nss-dscpstats/patches/0001-Fix_compilation_issue_when_DYNAMIC_DEBUG_is_disabled.patch Normal file
View File

@@ -0,0 +1,61 @@
From 4108235ef472b081b13bf7c4d16a689ca479676b Mon Sep 17 00:00:00 2001
From: Ayush Aggarwal <ayusagga@qti.qualcomm.com>
Date: Mon, 01 Dec 2025 15:24:37 +0530
Subject: [PATCH] [qca-nss-dscpstats] Fix build failure by adding debug level macro and required header
Change-Id: I2481de4be9444aae3fffec96ef93a72f80e02ee2
Signed-off-by: Ayush Aggarwal <ayusagga@qti.qualcomm.com>
---
diff --git a/Makefile b/Makefile
index 547ea23..aa3cc7a 100644
--- a/Makefile
+++ b/Makefile
@@ -9,3 +9,4 @@
ccflags-y += -I$(obj)/exports
ccflags-y += -Wall -Werror
+ccflags-y += -DNSS_DSCPSTATS_DEBUG_LEVEL=3
diff --git a/nss_dscpstats.h b/nss_dscpstats.h
index a3285bc..54331c8 100644
--- a/nss_dscpstats.h
+++ b/nss_dscpstats.h
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2024-2025 Qualcomm Innovation Center, Inc. All rights reserved.
*
* Permission to use, copy, modify, and/or distribute this software for any
* purpose with or without fee is hereby granted, provided that the above
@@ -20,6 +20,8 @@
#ifndef __NSSSTATDSCP__H
#define __NSSSTATDSCP__H
+#include <linux/netdevice.h>
+
#if defined(CONFIG_DYNAMIC_DEBUG)
/*
* If dynamic debug is enabled, use pr_debug.
@@ -32,19 +34,19 @@
/*
* Statically compile messages at different levels, when dynamic debug is disabled.
*/
-#if (nss_dscpstats_DEBUG_LEVEL < 2)
+#if (NSS_DSCPSTATS_DEBUG_LEVEL < 2)
#define nss_dscpstats_warn(s, ...)
#else
#define nss_dscpstats_warn(s, ...) pr_warn("%s[%d]:" s, __func__, __LINE__, ##__VA_ARGS__)
#endif
-#if (nss_dscpstats_DEBUG_LEVEL < 3)
+#if (NSS_DSCPSTATS_DEBUG_LEVEL < 3)
#define nss_dscpstats_info(s, ...)
#else
#define nss_dscpstats_info(s, ...) pr_notice("%s[%d]:" s, __func__, __LINE__, ##__VA_ARGS__)
#endif
-#if (nss_dscpstats_DEBUG_LEVEL < 4)
+#if (NSS_DSCPSTATS_DEBUG_LEVEL < 4)
#define nss_dscpstats_trace(s, ...)
#else
#define nss_dscpstats_trace(s, ...) pr_info("%s[%d]:" s, __func__, __LINE__, ##__VA_ARGS__)